[IMPROVEMENT] Improve health check to verify Taskwarrior availability.#438
Merged
its-me-abhishek merged 2 commits intoCCExtractor:mainfrom Feb 3, 2026
Merged
[IMPROVEMENT] Improve health check to verify Taskwarrior availability.#438its-me-abhishek merged 2 commits intoCCExtractor:mainfrom
its-me-abhishek merged 2 commits intoCCExtractor:mainfrom
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
its-me-abhishek
requested changes
Jan 31, 2026
its-me-abhishek
approved these changes
Feb 3, 2026
Collaborator
|
Thanks for the PR @gaurav02081 |
Contributor
Author
Thanks :-) |
greedy-wudpeckr
pushed a commit
to greedy-wudpeckr/ccsync
that referenced
this pull request
Feb 3, 2026
CCExtractor#438) * feat: make health check fail when task binary is missing * updating the PR applying the check for the version --------- Co-authored-by: GAURAV KARMAKAR <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the health check endpoint by verifying that the Taskwarrior (task) binary is available on the system.
Previously, the health endpoint always returned 200 OK, even if Taskwarrior was missing. The updated behavior returns 503 Service Unavailable with a clear status message when the required binary is not found, ensuring the service only reports itself as healthy when it can actually function
Checklist
npx prettier --write .(for formatting)gofmt -w .(for Go backend)npm test(for JS/TS testing)Additional Notes
I have verified the changes locally by simulating a missing Taskwarrior dependency inside the running container !
Baseline (normal state):
curl -s -i http://localhost:8000/healthReturns:
Simulated failure (Taskwarrior removed):
Returns:
Restored dependency:
Returns:
---> This change helps catch misconfigured or broken environments.